Simplify pattern matching #120875
Open
Simplify pattern matching #120875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>refactoring
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
reviewed
Jan 27, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
This is nice. But yeah, let's merge it later if we can't backport it now.
Member
|
+1 on the style however backporting is a big concern. To avoid conflicts, I suggest postponing the style changes until 9.0 is released and 8.x is closed when the number of backwards will significantly slow down. |
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/LocalExecutionPlanner.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies pattern matching in Analyzer and LocalExecutionPlanner.
Please note, this relies on java 21+ syntax so this will not be backported to 8.x and is going to be merged a bit later.